git.kernel.org

crypto: arm64/crc32 - add non-SIMD scalar fallback - kernel/git/torvalds/linux.git - Linux kernel source tree

  • ️Mon Jul 24 2017
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-07-24 11:28:07 +0100
committerHerbert Xu <herbert@gondor.apana.org.au>2017-08-04 09:27:17 +0800
commit15c7d8f8a2c7c86cb36f4d0273a1b2b2c9a479d7 (patch)
treee1f7cc5d7178662e82431b4471eab05784323e87
parent2dde374e1ff0663ca46b343949c242959028f976 (diff)
downloadlinux-15c7d8f8a2c7c86cb36f4d0273a1b2b2c9a479d7.tar.gz

crypto: arm64/crc32 - add non-SIMD scalar fallback

The arm64 kernel will shortly disallow nested kernel mode NEON, so add a fallback to scalar C code that can be invoked in that case. Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

-rw-r--r--arch/arm64/crypto/crc32-ce-glue.c11

1 files changed, 6 insertions, 5 deletions

diff --git a/arch/arm64/crypto/crc32-ce-glue.c b/arch/arm64/crypto/crc32-ce-glue.c
index eccb1ae9006410..624f4137918ce5 100644
--- a/arch/arm64/crypto/crc32-ce-glue.c
+++ b/arch/arm64/crypto/crc32-ce-glue.c

@@ -1,7 +1,7 @@

/*

* Accelerated CRC32(C) using arm64 NEON and Crypto Extensions instructions

*

- * Copyright (C) 2016 Linaro Ltd <ard.biesheuvel@linaro.org>

+ * Copyright (C) 2016 - 2017 Linaro Ltd <ard.biesheuvel@linaro.org>

*

* This program is free software; you can redistribute it and/or modify

* it under the terms of the GNU General Public License version 2 as

@@ -19,6 +19,7 @@

#include <asm/hwcap.h>

#include <asm/neon.h>

+#include <asm/simd.h>

#include <asm/unaligned.h>

#define PMULL_MIN_LEN 64L /* minimum size of buffer

@@ -105,10 +106,10 @@ static int crc32_pmull_update(struct shash_desc *desc, const u8 *data,

length -= l;

}

- if (length >= PMULL_MIN_LEN) {

+ if (length >= PMULL_MIN_LEN && may_use_simd()) {

l = round_down(length, SCALE_F);

- kernel_neon_begin_partial(10);

+ kernel_neon_begin();

*crc = crc32_pmull_le(data, l, *crc);

kernel_neon_end();

@@ -137,10 +138,10 @@ static int crc32c_pmull_update(struct shash_desc *desc, const u8 *data,

length -= l;

}

- if (length >= PMULL_MIN_LEN) {

+ if (length >= PMULL_MIN_LEN && may_use_simd()) {

l = round_down(length, SCALE_F);

- kernel_neon_begin_partial(10);

+ kernel_neon_begin();

*crc = crc32c_pmull_le(data, l, *crc);

kernel_neon_end();