phabricator.wikimedia.org

⚓ T109525 "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE

  • ️Tue Aug 18 2015

Comment Actions

alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (T109525)$ grep "mwedit\." modules/ve-mw/* -R
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js:		ve.track( 'mwedit.abort', {
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js:		ve.track( 'mwedit.abort', {
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js:			ve.track( 'mwedit.abort', { type: 'switchwithout', mechanism: 'navigate' } );
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js:			ve.track( 'mwedit.abort', { type: 'switchnochange', mechanism: 'navigate' } );
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js:				ve.track( 'mwedit.abort', { type: 'switchwith', mechanism: 'navigate' } );
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js:				ve.track( 'mwedit.ready' );
modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js:		ve.track( 'mwedit.init', initData );
modules/ve-mw/init/ve.init.mw.trackSubscriber.js:	ve.trackSubscribe( 'mwedit.', function ( topic, data, timeStamp ) {
modules/ve-mw/init/ve.init.mw.TargetEvents.js:		ve.track( 'mwedit.saveIntent' );
modules/ve-mw/init/ve.init.mw.TargetEvents.js:		ve.track( 'mwedit.saveAttempt' );
modules/ve-mw/init/ve.init.mw.TargetEvents.js:		ve.track( 'mwedit.saveSuccess', {
modules/ve-mw/init/ve.init.mw.TargetEvents.js:		ve.track( 'mwedit.saveFailure', data );
alex@alex-laptop:~/Development/MediaWiki/extensions/VisualEditor (T109525)$

Need to figure out how all of this is supposed to really work (should VE log for all targets or just DesktopArticleTarget) and how MobileFrontend is supposed to deal with logging events for one editor but not another. Preferably before the patch for T110272 starts getting run somewhere important and leaves confusing duplicated/missing logs.