⚓ T119923 Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text
- ️Tue Dec 01 2015
Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text
Closed, ResolvedPublic8 Estimated Story Points
Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text
Closed, ResolvedPublic8 Estimated Story Points
Steps to reproduce:
- Open a page with VE which has link in it
- Place the cursor at the beginning of the link text
- Now click on the remove link icon
Observed Result:
It does not remove the link from the text.
Event Timeline
Ryasmeen raised the priority of this task from to Needs Triage.
Jdforrester-WMF renamed this task from Cannot remove link if the cursor is at the beginning of the link text to Clicking the 'remove' button in the link context doesn't work if the cursor is at the beginning of the link text.Dec 1 2015, 8:06 PM
Delving into this, in ve.ui.AnnotationContextItem.prototype.onClearButtonClick, fragment is correct in both circumstances but fragment.getAnnotations( true ) doesn't return the right thing. I guess ve.dm.SurfaceFragment#getAnnotations needs to be updated to have a method of asking if it's "inside" or "outside" when at the start of a link/other 'cursored' annotation? @dchan?
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits