phabricator.wikimedia.org

⚓ T215608 Table border collapse in Timeless

  • ️Fri Feb 08 2019

Table border collapse in Timeless

Hello,
Timeless uses the property "border-collapse:collapse;", that causes an issue with custom css for tables like the property "border-radius".

Event Timeline

Comment Actions

Hi @Roumpf, do you have some screenshots of this issue and/or URLs to example pages where the problem is happening? Thanks!

Comment Actions

Also had this issue. As a temporary workaround, go to the MediaWiki:Timeless.css page on your wiki and add:

table {
  border-collapse: separate;
}

To reproduce this issue, simply try creating a table with rounded borders on a wiki:

{| style="border: 2px solid red; border-radius: 5px;"
! Header !! Header
|-
| Cell || Cell
|}

The expected result is rounded corners. The actual result is square corners. This works fine on non-Timeless skins because Timeless is the only one that has:

table {
  border-collapse: collapse;
}

If there isn't a valid reason for Timeless to have that property, please remove it.

Comment Actions

The reason for the border collapse was to get 1px borders between the cells instead of 2px, but evidently the default wikitable styles don't need that, which is interesting...

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits