phabricator.wikimedia.org

⚓ T41621 Refactor VisualEditor editing plugin for Cite back into the Cite extension

  • ️Fri Aug 24 2012

Refactor VisualEditor editing plugin for Cite back into the Cite extension

Closed, ResolvedPublic8 Estimated Story Points

Depends on VisualEditor having a (stable) API. As soon as it is considered stable enough, we can implement support for it in the Cite extension using whatever hook/api it offers.

Also needs detection since there are (obviously) wikis that have Cite but not VisualEditor. So probably some conditionally loaded module.

Event Timeline

Comment Actions

Adding 'javascript' keyword, because I think this is JavaScript related...

Comment Actions

In Bug 13127 comment 34 anomie wrote
"Since Parsoid has reimplemented the Cite extension in their own code, any fixes to Cite are going to be very difficult to get merged unless someone wants to do all the work twice, once in PHP and once in nodejs."

James: Quim wondered if this means that all Cite bugs.docs can be eventually and officially deprecated.

Any vague timeframe for this ticket, assuming that Trevor still works on this?

Comment Actions

(In reply to Andre Klapper from comment #3)

In Bug 13127 comment 34 anomie wrote
"Since Parsoid has reimplemented the Cite extension in their own code, any
fixes to Cite are going to be very difficult to get merged unless someone
wants to do all the work twice, once in PHP and once in nodejs."

That's a totally different issue about Parsoid's Cite vs Cite.php; this bug is about the location of code currently in the VisualEditor-MediaWiki repo that should be moved to the Cite extension's repository, like we did for <math> etc. Not sure if there's a bug about that?

James: Quim wondered if this means that all Cite bugs.docs can be eventually
and officially deprecated.

That's a question for the mythical other bug (but I'd say no).

Any vague timeframe for this ticket, assuming that Trevor still works on
this?

I'd want it to settle down a little more before the code was transitioned, but probably in a few months' time.

nshahquinn-wmf renamed this task from Cite: Refactor VisualEditor editing plugin for Cite back into the Cite extension to Refactor VisualEditor editing plugin for Cite back into the Cite extension.Jul 24 2015, 3:18 AM

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits