phabricator.wikimedia.org

⚓ T62928 WikiEditor: Provide some basic formatting and action keyboard shortcut commands

  • ️Thu Feb 06 2014

WikiEditor: Provide some basic formatting and action keyboard shortcut commands

Closed, ResolvedPublicFeature

CTRL/CMD+B for bolding highlighted text
CTRL/CMD+I for italicising highlighted text
CTRL/CMD+U for underline highlighted text

CTRL+1,2,3 for H1,H2, H3, etc

CTRL/CMD+K for linking highlighted text


Version: master
Severity: enhancement

Event Timeline

bzimport added a subscriber: Unknown Object (MLST).

Comment Actions

Moving to WikiEditor; we're probably going to kill the difference between the two, but for now…

Comment Actions

I'm about to implement the shortcuts in Convenient-Discussions as this is requested by users and I would rather not implement this apart from WikiEditor which Convenient Discussions employs. But if there is no activity in this task, I will have to.

Comment Actions

The currently merged patch is a step in the good direction, but it doesn’t contain any indication for editors that they can press certain shortcuts to press the buttons. Would be good to add that.

Comment Actions

@SD0001 also, just as a note, is Ctrl+1/2/3/4/5 not being a thing intentional? Those are available in the visual editor and seem very useful to have.

Comment Actions

Submitted the revert above because the patch basically makes it impossible for me to copy/paste things, since it hijacks Ctrl+C and Ctrl+V on dvorak keyboards (and possibly other layouts too?). The revert commit message has suggestions for how to fix this.

Comment Actions

AFAIK he new provided patch and the suggestion would make it impossible to use this feature for people on non-Latin keyboards (since e.key for K doesn’t match to K or k on a Russian keyboard, it would match to Л or л), therefore reducing the usability of this tremendously. I understand the concern with Dvorak keyboards, but maybe there are better ways to resolve this than this.

Comment Actions

AFAIK he new provided patch and the suggestion would make it impossible to use this feature for people on non-Latin keyboards (since e.key for K doesn’t match to K or k on a Russian keyboard, it would match to Л or л), therefore reducing the usability of this tremendously. I understand the concern with Dvorak keyboards, but maybe there are better ways to resolve this than this.

Did you test this? My understanding is that when Cmd/Ctrl modifiers are held pressed, e.key will be k even on a non-Latin keyboard. Caps lock also doesn't make a difference with Cmd/Ctrl pressed, e.key is always in lowercase.

Comment Actions

Only like this:

$( '#wpTextbox1' ).on( 'keydown', ( e ) => {
	console.log( e.key );
} );

image.png (243×506 px, 4 KB)

Comment Actions

Noting that I am now unable to copy/paste in the editor since I use Dvorak. It looks like this will be reverted by next Thursday, but any workaround in the meantime?

Comment Actions

Workaround is to turn on syntax highlighting. The shortcuts don't work with CodeMirror enabled.

Comment Actions

Both of those links work fine! The only issue for me is in the normal editor ("action=edit"), when syntax highlighting is off.

Comment Actions

This is quite frustrating for dvorak users ... any timeframe for it being reverted / help pointing out how to turn syntax highlighting on? Surprised this wasn't mentioned in yesterday's Tech News.

Comment Actions

To turn on syntax highlighting, click the highlighter icon in the toolbar.

Screenshot 2024-10-16 at 12.05.10 AM.png (456×1 px, 75 KB)

Comment Actions

To turn on syntax highlighting, click the highlighter icon in the toolbar.

Screenshot 2024-10-16 at 12.05.10 AM.png (456×1 px, 75 KB)

Aah, thanks! That workaround does work well.

Comment Actions

I still think Ctrl+1/2/3/4/5/6 should’ve been also added. It was also in the task description. I don’t think resolving this task without it is satisfactory enough.

Comment Actions

You can file a separate task for that – those are more controversial as they conflict with browser shortcuts for navigating between tabs on Windows. This ticket is for "basic formatting and action keyboard shortcut commands". (Not to mention being harder to implement as the VE behaviour is to use Control key instead of Cmd on Mac.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits